-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NONEVM-984][solana] - Reorg Detection + lighter rpc call #951
Draft
Farber98
wants to merge
35
commits into
backup-branch-fee-bumping
Choose a base branch
from
nonevm-984-reorg
base: backup-branch-fee-bumping
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,214
−275
Draft
Changes from 33 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
bdf3457
track status on each signature to detect reorgs
Farber98 3ad2bc8
move things arround + add reorg detection
Farber98 4fd327a
linting errors
Farber98 2b29c33
fix some state tracking instances
Farber98 a6ce47b
remove redundant sig update
Farber98 3a6e643
move state from txes to sigs
Farber98 f4c6069
fix listAllExpiredBroadcastedTxs
Farber98 f027aeb
handle reorg after confirm cycle
Farber98 8c18891
associate sigs to retry ctx
Farber98 2902ec0
remove unused ctx
Farber98 1c1f723
add errored state and remove finalized
Farber98 6bc0c62
comment
Farber98 05442b2
Revert "comment"
Farber98 9b27a5b
Revert "remove unused ctx"
Farber98 ee14b60
Revert "associate sigs to retry ctx"
Farber98 d1f1ae7
Revert "fix listAllExpiredBroadcastedTxs"
Farber98 8911df2
Revert "move state from txes to sigs"
Farber98 52ce0e9
fix tx state
Farber98 fbbe978
address feedback
Farber98 cef6a91
fix ci
Farber98 3b3a71b
fix lint
Farber98 ef782c3
handle multiple sigs case
Farber98 08b0c6e
improve comment
Farber98 63a5f3f
improve logic and comments
Farber98 23f42d1
address feedback
Farber98 4a20622
Merge branch 'backup-branch-fee-bumping' into nonevm-984-reorg
Farber98 53948e1
add comment
Farber98 fdc8068
tests and fix some bugs
Farber98 34045ae
Merge branch 'backup-branch-fee-bumping' into nonevm-984-reorg
Farber98 10e5d9d
address feedback
Farber98 0a4b5aa
Merge branch 'backup-branch-fee-bumping' into nonevm-984-reorg
Farber98 5b34579
Merge branch 'backup-branch-fee-bumping' into nonevm-984-reorg
Farber98 17769f7
get height instead of whole block optimization
Farber98 d6fb891
fix mocks on expiration
Farber98 b6f4729
fix test
Farber98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is out of scope of the reorg, but pushing it here so we don't need to make a separate merge: smartcontract-it.atlassian.net/browse/NONEVM-1015