[NONEVM-984][solana] - Reorg Detection + lighter rpc call #951
+1,214
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farber98
had a problem deploying
to
integration
GitHub Actions
Failure
Farber98
had a problem deploying
to
integration
GitHub Actions
Failure
Farber98
had a problem deploying
to
integration
GitHub Actions
Failure
Farber98
had a problem deploying
to
integration
GitHub Actions
Failure
Farber98
had a problem deploying
to
integration
GitHub Actions
Failure
Farber98
had a problem deploying
to
integration
GitHub Actions
Failure
Farber98
commented
Dec 12, 2024
| @@ -570,14 +640,14 @@ func (txm *Txm) handleFinalizedSignatureStatus(sig solanaGo.Signature) { | |||
| // An expired tx is one where it's blockhash lastValidBlockHeight (last valid block number) is smaller than the current block height (block number). | |||
| // If any error occurs during rebroadcast attempt, they are discarded, and the function continues with the next transaction. | |||
| func (txm *Txm) rebroadcastExpiredTxs(ctx context.Context, client client.ReaderWriter) { | |||
| currBlock, err := client.GetLatestBlock(ctx) | |||
| if err != nil || currBlock == nil || currBlock.BlockHeight == nil { | |||
| blockHeight, err := client.GetLatestBlockHeight(ctx) | |||
There was a problem hiding this comment.
this is out of scope of the reorg, but pushing it here so we don't need to make a separate merge: https://smartcontract-it.atlassian.net/browse/NONEVM-1015
Farber98
commented
Dec 12, 2024
| @@ -331,6 +333,19 @@ func (c *Client) GetLatestBlock(ctx context.Context) (*rpc.GetBlockResult, error | |||
| return v.(*rpc.GetBlockResult), err | |||
| } | |||
|
|
|||
| // GetLatestBlockHeight returns the latest block height of the node based on the configured commitment type | |||
There was a problem hiding this comment.
this is out of scope of the reorg, but pushing it here so we don't need to make a separate merge: smartcontract-it.atlassian.net/browse/NONEVM-1015
Farber98
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tickets
Soak Testing