Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit metrics reservoir implementation #24

Open
vajda opened this issue Jul 5, 2017 · 0 comments
Open

Revisit metrics reservoir implementation #24

vajda opened this issue Jul 5, 2017 · 0 comments
Milestone
Metrics

Comments

@vajda
Copy link

vajda commented Jul 5, 2017

Currently, metrics use default reservoir which is ExponentiallyDecayingReservoir.
Depending on implementation of #23, this might be already taken care of. If not, usage of SlidingTimeWindowReservoir should be considered, or even better configuration option to setup any of the following:

  • ExponentiallyDecayingReservoir
  • SlidingTimeWindowReservoir
  • SlidingWindowReservoir
  • UniformReservoir
@nivancevic nivancevic added this to the Metrics milestone Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Metrics
Development

No branches or pull requests
2 participants
@nivancevic @vajda