New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate using `Popen(shell=False, ...)` #250

Open

smarr opened this issue Aug 20, 2024 · 1 comment

Labels

Owner

smarr commented Aug 20, 2024

Should we avoid using the shell for running commands?

Think this is a major change at the core of ReBench.
So, we'd probably need to carefully test this.
See #248 (comment)

smarr added the help-wanted label

Owner Author

smarr commented Aug 20, 2024

At the moment, we request explicitly the use of a shell here:
https://github.com/smarr/ReBench/blob/master/rebench/executor.py#L532

However, we run build commands without shell here:
https://github.com/smarr/ReBench/blob/master/rebench/executor.py#L397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment