Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Attestation: webhook data and certificate enrichment #1527

Open
jamesez opened this issue Sep 8, 2023 · 2 comments
Open

Device Attestation: webhook data and certificate enrichment #1527

jamesez opened this issue Sep 8, 2023 · 2 comments
Assignees
Labels
enhancement needs triage Waiting for discussion / prioritization by team

Comments

@jamesez
Copy link

jamesez commented Sep 8, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Webhooks should be given as much of the attestation as possible, so that the hook can make decisions about whether to issue the certificate (this is similar to #1526).

Additionally, webhooks should be able to enrich the certificate from that attestation.

Why is this needed?

By giving a webhook the full attestation data, it can make decisions about whether the certificate should be issued at all - say, by verifying that the OS is above some minimum, and that the device is present in the MDM database.

Additionally, we want to carry the attested OS version OID into the finished certificate, so a partner service could make their own decisions about permitting a device on the network, without that service needing to ask our MDM or some other service via a back-channel.

@jamesez jamesez added enhancement needs triage Waiting for discussion / prioritization by team labels Sep 8, 2023
@jessepeterson
Copy link

I'd ask that the whole attestation leaf certificate be handed over to the webhook/thing making the decision (perhaps in addition to any parsed-out attestation data). In this way 3rd parties can verify the cert request however they wish.

@jamesez
Copy link
Author

jamesez commented Sep 9, 2023

+1 to @jessepeterson’s suggestion that the entire leaf be sent to the hook.

@hslatman hslatman self-assigned this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

No branches or pull requests

3 participants