Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: disable or enable tls only or non-tls service ports only #17

Open
jessebot opened this issue Jul 29, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@jessebot
Copy link
Collaborator

jessebot commented Jul 29, 2023

Description of the change

We currently create a certificate for you like this:
https://github.com/jessebot/coturn-chart/blob/3e770404a9482b4381e9296951a1a4164173fa18/charts/coturn/values.yaml#L43-L46

That's left over from the chart we forked. We don't even use that value in the two service templates we have 🤦 We should change that to tls.enabled and allow for an tls.existingSecret. When tls.enabled is true, we should maybe not allow any unencrypted traffic, so we should not create the unencrypted ports in the services here and here:

https://github.com/jessebot/coturn-chart/blob/3e770404a9482b4381e9296951a1a4164173fa18/charts/coturn/templates/service-tcp.yaml#L14-L20

https://github.com/jessebot/coturn-chart/blob/3e770404a9482b4381e9296951a1a4164173fa18/charts/coturn/templates/service-udp.yaml#L14-L20

Likewise if tls.enabled is false we should not create the tls ports and instead only create the ports above.

Benefits

This allows you to be completely secure... or not, without the weird in between, as right now, we create both tls and non-tls ports for both UDP/TCP services.

Possible drawbacks and Additional Comments

I suppose it might make sense to allow for both to be configured? Maybe we also need coturn.ports.tls.enabled and coturn.ports.insecure.enabled? 🤔 Open to better names for the values there.

Do we even need two services btw? Can we just have one? 🤷

@jessebot jessebot added the enhancement New feature or request label Jul 29, 2023
@jessebot
Copy link
Collaborator Author

@cloudymax interested in your thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants