Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for multiple users declaritively #14

Open
jessebot opened this issue Jul 29, 2023 · 0 comments
Open

Feature: Add support for multiple users declaritively #14

jessebot opened this issue Jul 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jessebot
Copy link
Collaborator

Describe your Issue

I'd like to support adding more than one user to match what is possible in the coturn/coturn:examples/etc/turnserver.conf

We should probably convert this into an array: https://github.com/jessebot/coturn-chart/blob/8650cf1ce74ec2a2dc5a720235779c58fb9eefe2/charts/coturn/values.yaml#L128-L140

The array in the values.yaml could look like this:

# most coturn config parameters that you really need
coturn:
  users:
   - username:
      password:
      secretKeys:
        username: username
        password: password

The question is how do we handle this securely? Right now, these values get passed into a secret, to avoid having plain text passwords, like this: https://github.com/jessebot/coturn-chart/blob/8650cf1ce74ec2a2dc5a720235779c58fb9eefe2/charts/coturn/templates/auth-secret.yaml#L8-L14

And then they're passed into an init container in the deployment via an env var here: https://github.com/jessebot/coturn-chart/blob/8650cf1ce74ec2a2dc5a720235779c58fb9eefe2/charts/coturn/templates/deployment.yaml#L57-L74

So they can then be concatenated in via yq here: https://github.com/jessebot/coturn-chart/blob/8650cf1ce74ec2a2dc5a720235779c58fb9eefe2/charts/coturn/templates/deployment.yaml#L119

The issue is I don't know what to do here for the init container. I guess we can just make the secret more complex, or we could change the init container to possibly add the users via actual turnserver cli commands? 🤔 I'm open to suggestions and PRs.

@jessebot jessebot added the enhancement New feature or request label Jul 29, 2023
@jessebot jessebot changed the title Add support for multiple users Feature: Add support for multiple users Jul 29, 2023
@jessebot jessebot changed the title Feature: Add support for multiple users Feature: Add support for multiple users declaritively Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant