Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cert creation #10

Merged
merged 4 commits into from
Nov 4, 2023
Merged

update cert creation #10

merged 4 commits into from
Nov 4, 2023

Conversation

cloudymax
Copy link
Collaborator

@cloudymax cloudymax commented Nov 4, 2023 •
edited
Loading

@jessebot jessebot self-requested a review November 4, 2023 12:12
jessebot
jessebot approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@jessebot jessebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but in the test we should do a helm install of the cnpg operator and also cert-manager

@jessebot jessebot merged commit 45e238a into main Nov 4, 2023
1 of 2 checks passed
@jessebot jessebot deleted the update-certs branch November 4, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebot jessebot jessebot approved these changes

Assignees

@cloudymax cloudymax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudymax @jessebot