Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Switcher to search for Teams/Players/Events #99

Open
zusorio opened this issue Jan 17, 2022 · 2 comments · May be fixed by #103
Open

Quick Switcher to search for Teams/Players/Events #99

zusorio opened this issue Jan 17, 2022 · 2 comments · May be fixed by #103
Labels
enhancement New feature or request qol section: server Relates to server or node scripts section: website Relates to website pages

Comments

@zusorio
Copy link
Collaborator

zusorio commented Jan 17, 2022

Is your feature request related to a problem? Please describe.
To go to a team/player/event a user first has to go to the correct tab for the category, wait for the page to load, then enter their search query. This is annoying and takes some time.

Describe the solution you'd like
A quick switcher that appears as an overlay on any page whenever the user presses a shortcut like ctrl/⌘+k. It should fuzzy search teams, players and events and jump to the corresponding page on enter. There could also be an option to immediately jump to subpages for the select item like brackets, played matches, branding, etc. using the arrow keys.

Describe alternatives you've considered
There could also just be a universal search tab, however this would still be another click before being able to search.

Additional context
GitHub has the option to use tab for searching inside the selected option, this could be nice.
image
image

@zusorio zusorio added enhancement New feature or request needs triage labels Jan 17, 2022
@slmnio slmnio added qol section: server Relates to server or node scripts section: website Relates to website pages and removed needs triage labels Jan 21, 2022
@slmnio
Copy link
Owner

slmnio commented Jan 21, 2022

I use the quick switcher all the time in Discord so would love to have it on SLMN.GG. I think the main thing is working out how to get the data for the switcher. Most stuff on the site uses its own cache of SLMN.GG which is events/teams/things it has loaded. We don't want it to load the entire site just to filter through them on the client.

It should all probably be handled by the server. As things are updated, they can be given an extra field which contains strings that could match a fuzzy search. For example, events could pull their name, their short name, series name and so on. ST4's array would look something like ["Avast's Sub Tourney 4", "subtourney", "Sub Tourney 4", "Avast's Sub Tourney", "June 2021"] just from the text fields on the record.

We'd also need to add either more descriptive fields or some sort of aliases list (there's actually one on the Teams table that we used for matching up stats from lobby names). The short name of events is not actually the shortest we use - "BPL3" and "ST4" are not actually on the database at all other than some redirects that aren't linked.

@slmnio
Copy link
Owner

slmnio commented Jan 21, 2022

👀

chrome_hhxs0y6oMI.mp4

@slmnio slmnio linked a pull request Jan 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qol section: server Relates to server or node scripts section: website Relates to website pages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants