Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes without quotes break detecting terminating parenthesis #64

Open
mjc-gh opened this issue Dec 1, 2016 · 6 comments
Open

Attributes without quotes break detecting terminating parenthesis #64

mjc-gh opened this issue Dec 1, 2016 · 6 comments
Assignees
@ixti

Comments

@mjc-gh
Copy link

mjc-gh commented Dec 1, 2016

vim-slim
ixti added a commit that referenced this issue Dec 1, 2016
@ixti
Respect attribute values without quotes
64dc9bc 
Resolves #64
@ixti
Copy link
Member

ixti commented Dec 1, 2016

@mikeycgto I have added a fix to the branch. Help with testing that branch is highly appreciated!
https://github.com/slim-template/vim-slim/tree/fix/qoutesless-attrs

@ixti ixti self-assigned this Dec 1, 2016
@mjc-gh
Copy link
Author

mjc-gh commented Dec 1, 2016

The fix works for me! Thanks so much!!

@ixti
Copy link
Member

ixti commented Dec 1, 2016

I'm mostly curious if this fix won't break anything in fact ;))

@ixti
Copy link
Member

ixti commented Dec 1, 2016

I'm gonna test it myself as well and will merge once I'm more or less certain it's not buggy

@mjc-gh
Copy link
Author

mjc-gh commented Dec 1, 2016 via email

@ixti
Copy link
Member

ixti commented Dec 1, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixti ixti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjc-gh @ixti