Update contributing.md #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshadkazmi42
requested a deployment
to
staging
GitHub Actions
Waiting
|
Hey @arshadkazmi42 👋 Thanks for sending this in too! While it's an appreciated change, I'd prefer grammatical changes aren't posted in standalone PRs. The current wording is clear so we can keep it as is for now. Also want to note that if we revisit these pages, we might want to be consistent across the projects of @slackapi. Updates to broken links, typos, and other fixes or additions to documentation are still so welcomed, but for now I'll close this PR 📚 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR swaps “fill out” with “complete,” which is slightly more formal and polished. It also uses single quotes for consistency with the rest of the document (e.g., good first contribution) in
contributing.mdRequirements