-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with older servers that support #rewind. #515
Draft
olleolleolle
wants to merge
1
commit into
slack-ruby:master
Choose a base branch
from
olleolleolle:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Pull Request Test Coverage Report for Build 9776811795Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9776811795Details
💛 - Coveralls |
olleolleolle
added a commit
to olleolleolle/slack-ruby-client
that referenced
this pull request
Jul 3, 2024
Pull Request Test Coverage Report for Build 9777240612Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9777240612Details
💛 - Coveralls |
olleolleolle
added a commit
to olleolleolle/slack-ruby-client
that referenced
this pull request
Jul 3, 2024
Pull Request Test Coverage Report for Build 9777379775Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9777379775Details
💛 - Coveralls |
olleolleolle
added a commit
to olleolleolle/slack-ruby-client
that referenced
this pull request
Jul 3, 2024
olleolleolle
changed the title
request.rb: Compatibility with rackup's WEBRick handler
Compatibility with older servers that support Jul 3, 2024
#rewind
.
olleolleolle
added a commit
to olleolleolle/slack-ruby-client
that referenced
this pull request
Jul 3, 2024
Pull Request Test Coverage Report for Build 9777483025Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9777501826Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9777501826Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9777483025Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9777483025Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9777501826Details
💛 - Coveralls |
olleolleolle
changed the title
Compatibility with older servers that support
Compatibility with older servers that support #rewind.
Jul 3, 2024
#rewind
.
Pull Request Test Coverage Report for Build 9777677201Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9777677201Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9777677201Details
💛 - Coveralls |
If you don't Coveralls is being annoying re-running on every commit... maybe you know how to turn this off? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment to make slack-ruby-client able to be used with Webrick via rackup gem.
The "rewind-read-rewind" used here:
slack-ruby-client/lib/slack/events/request.rb
Lines 39 to 47 in 9e6d117
...is no longer supported.
This change is about making the code compatible with older servers that offered rewind.