Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] The toolbar should add classes to its buttons #4281

Open
Nek- opened this issue Jul 1, 2024 · 0 comments · May be fixed by #4282
Open

[RFC] The toolbar should add classes to its buttons #4281

Nek- opened this issue Jul 1, 2024 · 0 comments · May be fixed by #4282

Comments

@Nek-
Copy link

Nek- commented Jul 1, 2024

Problem

While customizing the experience with Quill, you may need to add some HTML in the toolbar content. This is a behavior 100% supported by Quill and it's awesome!

What is not so awesome however is that the toolbar buttons are reset using selectors like .toolbar button. It means it will override entirely the CSS of your app... Even for the code you added! You will need to duplicate your CSS code, especially for Quill buttons.

Solution

The toolbar should add classes to its buttons so the themes do not target all buttons but only those managed by Quill!

Side information

Version: Quill v2.
Browser(s): All.
Code proposal: #4282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant