Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra badge variant #1621

Open
Tracked by #1100
jtalen opened this issue Nov 5, 2024 · 2 comments
Open
Tracked by #1100

Extra badge variant #1621

jtalen opened this issue Nov 5, 2024 · 2 comments
Labels
development enhancement New feature or request triage An issue needed triage

Comments

@jtalen
Copy link

jtalen commented Nov 5, 2024

Provide a general summary of the feature here

A badge is really handy for communicating status or counts. There are a few variants but we are missing a neutral (white variant).

🤔 Expected Behavior?

In our case we are using the badge in tree list. Per item we are showing the amount of items that are in this collection. This shouldn't get extra attention. But when a tree list item is selected or is in a hover state the background of the badge gives the proper contrast.

image

😯 Current Behavior

If we had used the primary subtle variant this would have pretty much the same color as the active or hover state of the tree list item. So contrast would be bit of an issue there

💁 Possible Solution

Provide an inverted or neutral variant of the badge

🔦 Context

See screenshots. This pattern is being used in several functionalities now

💻 Examples

No response

👤 Your name

Jeremy Talen

🧢 Your Product/Team

Magister

Tasks

No tasks being tracked yet.
@jtalen jtalen added development enhancement New feature or request triage An issue needed triage labels Nov 5, 2024
@github-project-automation github-project-automation bot moved this to 📥 Incoming in SL Design System Team Nov 5, 2024
@DanielleRameau
Copy link
Collaborator

DanielleRameau commented Nov 6, 2024

@jtalen we don't think it should be part of the badge component itself but can (maybe) an option in the tree view component once we start building it. I'll add this issue to the tree view component (#1100 )

@jtalen
Copy link
Author

jtalen commented Nov 21, 2024

We are using those numbers also in other list components
image

So maybe we can re-use that new specific part as a sub-component or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development enhancement New feature or request triage An issue needed triage
Projects
Status: 📥 Incoming
Development

No branches or pull requests

2 participants