Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection issues when using a sl-grid-selection-column and groupHeaders #1618

Open
1 task
PaulineKK opened this issue Nov 4, 2024 · 4 comments
Open
1 task
Labels
bug Something isn't working development triage An issue needed triage

Comments

@PaulineKK
Copy link

PaulineKK commented Nov 4, 2024

Provide a general summary of the issue here

When you toggle a group, the existing selection is removed.

🤔 Expected Behavior?

I expect the current selection to stay the same.

😯 Current Behavior

Whenever you collapse or expand a group, the selection you had is removed.

💁 Possible Solution

No response

🖥️ Steps to Reproduce

Start: Have a grid with multiple groups, all collapsed.

Step 1: Expand a group
Step 2: Select at least one item
Step 3: Expand another group

Error: Your selection is removed.

What browsers are you seeing the problem on? (only for bugs in code)

Chrome

If other, please specify.

No response

What operating system are you using?

Windows

👤 Your name

Pauline Kingma

🧢 Your product/team

Magister

🎨 Your Theme(s)

Magister

Tasks

@PaulineKK PaulineKK added bug Something isn't working development triage An issue needed triage labels Nov 4, 2024
@github-project-automation github-project-automation bot moved this to 📥 Incoming in SL Design System Team Nov 4, 2024
@Diaan
Copy link
Collaborator

Diaan commented Nov 5, 2024

@PaulineKK
Can you maybe provide an example (preferably code/proof of concept, but at least a video) of what you are trying to do? And also which version of the data-grid component you are using? We've recently updated the way selection works, so make sure you are using the latest version.

In our current version I've made this example:
Image
And that works as you expect, so we need a bit more information to be able to help you out.

I can't get the video to embed, but you can see how it works here:
https://github.com/user-attachments/assets/da00b6ff-26ba-4591-ab65-f778ece616d9

@PaulineKK
Copy link
Author

I'm using version: 0.1.12. (On SLDS Storybook the grid in Magister Theme is broken, Jeroen Z. advised me not to update because of that.) But if you have fixed this I would love to update, especially if this bug is fixed!

@Diaan
Copy link
Collaborator

Diaan commented Nov 5, 2024

I see the Magister theme is indeed severely broken 😅
We'll fix that first and then hopefully the issue you reported here will automatically be fixed, and otherwise we will have another look at it.

@DanielleRameau DanielleRameau moved this from 📥 Incoming to ⏳ Waiting for input in SL Design System Team Nov 6, 2024
@DanielleRameau
Copy link
Collaborator

@jpzwarte will check issue(s) with the grid within the Magister dev team to see how critical it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development triage An issue needed triage
Projects
Status: ⏳ Waiting for input
Development

No branches or pull requests

3 participants