Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prime Spiral is slow in renderring when grid gets large #3

Open
MrL1605 opened this issue Oct 26, 2020 · 0 comments
Open

Prime Spiral is slow in renderring when grid gets large #3

MrL1605 opened this issue Oct 26, 2020 · 0 comments
Assignees
@MrL1605
Labels
bug Something isn't working

Comments

@MrL1605
Copy link
Member

MrL1605 commented Oct 26, 2020

Fix the rendering by optimising it, as even grid size of 600 is observably slow.

Suggested problem and solution:

  • Problem is with innerHTML line, as we are re-rending the complete grid. Solution: Append new elements in the existing DOM instead of complete rerender
  • Problem is with usage of flexbox, not able to size hundreds of rows and column. Solution: Switch to canvas and keep logic of re-rendering the same
@MrL1605 MrL1605 self-assigned this Oct 26, 2020
@MrL1605 MrL1605 added the bug Something isn't working label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrL1605 MrL1605

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrL1605