Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output declarations by default on utility modules #289

Closed
vongohren opened this issue Apr 29, 2021 · 5 comments
Closed

Output declarations by default on utility modules #289

vongohren opened this issue Apr 29, 2021 · 5 comments

Comments

@vongohren
Copy link

On utility module making, there should be templated so that the declarations are created by default.
Right now there is no documentation or simple way to get declartions. One have to set it up self.
This issue was raised: single-spa/single-spa.js.org#361 (comment)

And it was agreed that declarations should be on by default for utility modules.

Right now I dont have time to add it, as Im raising forward to get our rebuild up and running and ready for release. If I find the time I will come back and fix it.

But the issue is here for a tracker.

@joeldenning
Copy link
Member

I may be able to get to this in the next couple weeks. If anyone else would like to contribute a PR for it, that would be welcome, too.

@gwinnem
Copy link

gwinnem commented Aug 3, 2021

Hi Joel, any progress with this yet ?

@joeldenning
Copy link
Member

joeldenning commented Aug 3, 2021

No. Feel free to contribute to the project with a pull request.

@joeldenning
Copy link
Member

I had some time today so I implemented this in #316

@joeldenning
Copy link
Member

This is released in [email protected]

Projects generated with the latest version of create-single-spa will automatically generate types. The link above has documentation for migrating existing projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants