Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-16550: Add support of object in "parent" field for teams - (Copy of PR #107) #149

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

hpatel41
Copy link
Contributor

Description of change

TDL-16550: Add support of object in "parent" field for teams

  • Added "object" datatype for the "parent" field in the "teams" stream

NOTE: Created parent-child teams from another account and verified the code change using Import API from the stitch UI

Manual QA steps

Risks

Rollback steps

  • revert this branch

@hpatel41 hpatel41 changed the title TDL-16550: Add support of object in "parent" field for teams TDL-16550: Add support of object in "parent" field for teams - (Copy of PR #107) Nov 30, 2021
@hpatel41 hpatel41 marked this pull request as ready for review November 30, 2021 12:46
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For posterity, this solves the same issues as #107 Going to update on that PR.

@KrisPersonal KrisPersonal merged commit 4306ec9 into master Nov 30, 2021
@KrisPersonal KrisPersonal deleted the teams-stream-parent-field branch November 30, 2021 18:47
@jcw-
Copy link

jcw- commented Dec 1, 2021

#151

AJWurts pushed a commit to villagelabsco/tap-github that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants