-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on IOS 15.1 Safari / Chrome #47
Comments
same here |
It might be the optional catch, can you try this please - #49 |
same here |
Are you sure your applying of my PR there is taking affect? Can you try to console log. And then can you have it console log the error when it happens. |
That's just it, there is no exception/error thrown, the execCommand() just fails to copy to clipboard (iOS Safari only). I tried a simpler example without this library using the same API commands and that works across browsers but not consistently in Safari. I suspect the bug is related to Safari's implementation of execCommand() but I have nothing to back this up. |
Experiencing this as well. We added these lines of code a long time ago specifically for iOS safari, however they no longer seem to be working. It's possible that due to updates on Safari that code is no longer working. However looks like Safari added support for the Clipboard API at v13.4. Which is great news because this repo is basically a bunch of hacks to get this functionality. |
I was facing the same problem for quite some time. And wasn't sure why it isn't working. How I approached
My test Test here Please help me test @Matt-Jensen , @thiessenp-cds. By the way, are any of you guys using Tailwind CSS or some sort of CSS reset? If this turns out to be valid, I can submit a PR, since it's just a tiny change. |
@www-chique great investigative work here! Yes I was also experiencing the issue on a site with Tailwinds reset styles. I'd like to help you debug more, but I've already migrated to the Clipboard API which works well for a critical majority of iOS Safari browsers. |
@www-chique Base on your investigation, I did a bit deeper debug, founded that it was:
caused the
And this invisible cause the |
This PR resolves the issue with copying on Safari. Turns out, a Docusaurus dependency has an [unpatched bug](sindresorhus/copy-text-to-clipboard#47). This closes hasura/graphql-engine#10341 and closes hasura/graphql-engine#10349.
I installed the lib and it work well on windows / android but it doesn't seem to copy anything on IOS 15.1 ipad.
Is it a known issue or is it supposed to work on latest IOS versions with Chrome and Safari?
The text was updated successfully, but these errors were encountered: