Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve descriptions of duplicates #462

Open
emjaymeow opened this issue Aug 25, 2024 · 4 comments
Open

Preserve descriptions of duplicates #462

emjaymeow opened this issue Aug 25, 2024 · 4 comments

Comments

@emjaymeow
Copy link

emjaymeow commented Aug 25, 2024

When running de-duplication, would it be possible to preserve the description of the deleted duplicates by also adding the description to the preserved image?

Example:

Lower quality(LQ) google photos image in album "Dog" with description: "This is a cute dog"
Higher quality(HQ) original of the same image not in any album with no description.

Current de-duplication behaviour:

  • De-duplication runs
  • removes the LQ image
  • ascociates the HQ image with the album "Dog"
  • the description of the LQ image is lost. The HQ image has no description.

Desired de-duplication behaviour:

  • De-duplication runs
  • removes the LQ image
  • ascociates the HQ image with the album "Dog"
  • the description of the LQ image gets applied to the HQ image. The HQ image now has the description "This is a cute dog".
@emjaymeow
Copy link
Author

I also just noticed the same happens on upload, when adding a google takeout zip with descriptions on the images. The descriptions get lost when my immich library already has the same images in higher quality.

It would be nice if the decription would be added to the higher quality version if it has none.

@simulot
Copy link
Owner

simulot commented Aug 27, 2024

That makes sense.
On the other hand, if you run the import several times, the description will accumulate descriptions.

I should add a parameter to control how takeout comments are handled:

  • remplace
  • added to existing comment
  • ignore

@emjaymeow
Copy link
Author

emjaymeow commented Aug 27, 2024

True, that would be nice.
And if "add to existing description" is chosen, maybe compare the strings and if they are exactly the same then leave them be.
And if they are different then merge/add them. Or make that another option?

Btw, thank you for this great tool and your efforts!

@simulot
Copy link
Owner

simulot commented Aug 27, 2024

The parameter list becomes a mess. I work on restructuring the command line argument parsing before.
Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants