Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address VisData does not contain firstFrameTime, defaulting to 0 error log #377

Open
meganrm opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@meganrm
Copy link
Contributor

meganrm commented Apr 24, 2024

Description

when I call goToTime from the binding simulator I get an error VisData does not contain firstFrameTime, defaulting to 0

Expected Behavior

no error log. I'm not sure when/how firstFrameTime gets set or why it's not set in this case, but there is a comment with this function that indicates this was not a finished feature

some possible fixes:

  1. maybe something needs to be changed with the implementation of the binding affinity app to set firstFrameTime that I'm not doing.
  2. Just remove the log? do we need to tell the users this is happening?

Reproduction

in the education app, change the input concentration using the slider

Environment

Any additional information about your environment. E.g. OS version, python version, browser etc.

@meganrm meganrm added the bug Something isn't working label Apr 24, 2024
@meganrm
Copy link
Contributor Author

meganrm commented Apr 24, 2024

here's the comment:
// Instead of requesting from the backend the time passed into this
// function, we request (time - firstFrameTime) because the backend
// currently assumes the first frame of every trajectory is at time 0.
//
// TODO: Long term, we should decide on a better way to deal with this
// assumption: remove assumption from backend, perform this normalization
// in simulariumio, or something else? One way might be to require making
// firstFrameTime a part of TrajectoryFileInfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants