Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the androidx libraries require AAPT2 in order to compile #804

Open
william-ferguson-au opened this issue Jul 24, 2021 · 0 comments
Assignees

Comments

@william-ferguson-au
Copy link
Contributor

AMP only uses AAPT (1). AAPT2 has been available since Android 24
https://developer.android.com/studio/command-line/aapt2

The resource value file in AndroidX.savedState has a structure that cannot be parsed by AAPT.
I suspect there will be others.

AAPT2 explicitly splits resource packaging into compiling and linking (which we knew needed to be done because AMP invokes it twice, once in GenerateResources and once when packaging an AAR/APK)

We need to

  1. Split the AaptPackageCommandBuilder into Compile and Link classes or maybe just constructable based on command.
  2. Move all Aapt classes into an aapt package
  3. Create Aapt2 versions
  4. Have factory choose which classes to use, based on whether AAPT2 exists in build tools folder
  5. Update all clients.
@william-ferguson-au william-ferguson-au self-assigned this Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant