-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulator-start goal gives a timeoutException even if the emulator is been started #752
Comments
Maybe you can fix the latest maven android plugin emulator mojo ? I don't think anybody else is going to have a go at it.... |
What should I have to fix?? You can use my temporarily solution on my repository. |
I suggest that we cut support for the emulator in the plugin. IMHO the
plugin already suffers badly from being a Swiss army knife.
…On Wed., 28 Jun. 2017, 8:37 pm Angelo Manganiello, ***@***.***> wrote:
What should I have to fix?? You can use my temporarily solution on my
repository.
Or, if you have other requests, you can open an issue on my
maven-android-emulator-plugin and give a donation in the
https://github.com/amanganiello90/maven-gitflow-plugin because I already
work in a full-time job daily. Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#752 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAo7h6Iw4jlGyii_C1JqYy77D3JKITa_ks5sI0Y2gaJpZM4LKrhZ>
.
|
@william-ferguson-au I don't understant what we will do. Will we fork the maven-android-plugin and resolve it or eliminate the goal that doesn't work? |
I vote for eliminating the goal.
Let another plugin focus on the emulator.
…On Thu., 29 Jun. 2017, 1:07 am Angelo Manganiello, ***@***.***> wrote:
@william-ferguson-au <https://github.com/william-ferguson-au> I don't
understant what we will do. Fork the maven-android-plugin and resolve it or
eliminate the goal that doesn't work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#752 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAo7h9V3qlF4jk0bBko0-gf_pDQxOxCHks5sI4VPgaJpZM4LKrhZ>
.
|
Maybe I can modify the mojo goal class to insert my node script that I have created in my repo. Then I can use trireme (https://github.com/apigee/trireme) to call this scripts in the mojo. So, after this, I open a pull request to integrate it. |
I would rather not use some nodejs code but I would like to continue having the goal. I think I am happy to just release the plugin as a new version to get the changes out and just have those goals broken for now. And then we can decide on removing or fixing based on the feedback. |
@mosabua I don't want to use nodejs code instead of the maven plugin. I'm working on a maven plugin that executes nodejs code in java. So It will be very easy to integrate my script using my core-class in the maven-android-plugin mojo in order to fix the problem in the start-emulator. When it is ready the core, I will be able to create a pull request on your plugin. As your goal doesn't work and you want to break it, you have nothing to lose to integrate a new mojo that can assolve the start-emulator job. |
Sounds good. I would love to pull your stuff in.. however please do not submit it as a new mojo. Just fix the existing mojo ;-) |
Yes, I have said new mojo to refer the existing goal integrated and fixed |
I have opened a pull request that fix the goal entirely with java code. |
The 4.4.3 version doesn't work on Windows for the vbs script. However the 4.3.0 version runs but with the problem exposed in the issue title. That is the emulator is started (and up running) but maven fails with a timeout exception.
Temporarily, I have resolved the problem with a combination of maven antrun plugin and a node.js script.
You can download this on: https://github.com/amanganiello90/maven-android-emulator-plugin
The text was updated successfully, but these errors were encountered: