Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator-start goal gives a timeoutException even if the emulator is been started #752

Open
ghost opened this issue Dec 12, 2016 · 11 comments

Comments

@ghost
Copy link

ghost commented Dec 12, 2016

The 4.4.3 version doesn't work on Windows for the vbs script. However the 4.3.0 version runs but with the problem exposed in the issue title. That is the emulator is started (and up running) but maven fails with a timeout exception.
Temporarily, I have resolved the problem with a combination of maven antrun plugin and a node.js script.
You can download this on: https://github.com/amanganiello90/maven-android-emulator-plugin

@Shusshu
Copy link
Member

Shusshu commented Jun 28, 2017

Maybe you can fix the latest maven android plugin emulator mojo ? I don't think anybody else is going to have a go at it....

@ghost
Copy link
Author

ghost commented Jun 29, 2017

What should I have to fix?? You can use my temporarily solution on my repository.
Or, if you have other requests, you can open an issue on my maven-android-emulator-plugin and give a donation in the https://github.com/amanganiello90/maven-gitflow-plugin because I already work in a full-time job daily. Thanks

@william-ferguson-au
Copy link
Contributor

william-ferguson-au commented Jun 29, 2017 via email

@ghost
Copy link
Author

ghost commented Jun 29, 2017

@william-ferguson-au I don't understant what we will do. Will we fork the maven-android-plugin and resolve it or eliminate the goal that doesn't work?

@william-ferguson-au
Copy link
Contributor

william-ferguson-au commented Jun 29, 2017 via email

@ghost
Copy link
Author

ghost commented Jun 30, 2017

Maybe I can modify the mojo goal class to insert my node script that I have created in my repo. Then I can use trireme (https://github.com/apigee/trireme) to call this scripts in the mojo. So, after this, I open a pull request to integrate it.

@mosabua
Copy link
Member

mosabua commented Jun 30, 2017

I would rather not use some nodejs code but I would like to continue having the goal. I think I am happy to just release the plugin as a new version to get the changes out and just have those goals broken for now. And then we can decide on removing or fixing based on the feedback.

@ghost
Copy link
Author

ghost commented Jun 30, 2017

@mosabua I don't want to use nodejs code instead of the maven plugin. I'm working on a maven plugin that executes nodejs code in java. So It will be very easy to integrate my script using my core-class in the maven-android-plugin mojo in order to fix the problem in the start-emulator. When it is ready the core, I will be able to create a pull request on your plugin. As your goal doesn't work and you want to break it, you have nothing to lose to integrate a new mojo that can assolve the start-emulator job.

@mosabua
Copy link
Member

mosabua commented Jun 30, 2017

Sounds good. I would love to pull your stuff in.. however please do not submit it as a new mojo. Just fix the existing mojo ;-)

@ghost
Copy link
Author

ghost commented Jun 30, 2017

Yes, I have said new mojo to refer the existing goal integrated and fixed

@ghost ghost mentioned this issue Aug 12, 2017
@ghost
Copy link
Author

ghost commented Aug 12, 2017

I have opened a pull request that fix the goal entirely with java code.
Review it and maybe you can release the fix.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants