Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh.get_slice() for Tree meshes? #255

Open
lheagy opened this issue Jul 15, 2021 · 1 comment
Open

mesh.get_slice() for Tree meshes? #255

lheagy opened this issue Jul 15, 2021 · 1 comment

Comments

@lheagy
Copy link
Member

lheagy commented Jul 15, 2021

The __plot_slice_tree method has a lot of logic for grabbing the correct values to plot in a plotslice. When generating plots with additional layers (e.g. a quiver plot for MVI) a lot of this logic needs to be repeated.

What do folks think of just having this be a method on a TreeMesh? and then __plot_slice_tree calls this and is more about the logic for plotting (e.g. starting at line 2106 at the moment)

@lheagy
Copy link
Member Author

lheagy commented Jul 15, 2021

just realizing that we can use the CCv call to get the plot that I want, but still, would it be worthwhile to separate the logic of getting the slice + viewing the slice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant