Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with React 19 #230

Open
titouancreach opened this issue Jun 13, 2024 · 3 comments
Open

Issues with React 19 #230

titouancreach opened this issue Jun 13, 2024 · 3 comments
Assignees
Labels
invalid This doesn't seem right @viselect/react React package

Comments

@titouancreach
Copy link

titouancreach commented Jun 13, 2024

What is the problem?

Hello, I have issue with using this package (React version with React 19).

Error: Cannot read properties of undefined (reading 'ReactCurrentDispatcher')
    at eval (viselect.mjs:250:15)
    at gr (viselect.mjs:661:4)
    at eval (viselect.mjs:663:26)

What is the current behavior?

The current behavior is that it throw with the exception I pasted above.


I've done some ressearch and it appears that is the problem when we use multiple React Version together.
So, I've copy/pasted the file SelectionArea.tsx directly into my project and installed vanilla package directly, and it worked ! (and that's ok for me).

I think a good way (and modern way) to distribute the React package should be to only transpile the tsx to jsx. I believe all people that use react have already a bundler and, the file would be build and run with the current version of React.

Anyway, it works and it does exactly what I was looking for thank you !

Please provide the steps to reproduce and create a CodeSandbox.

What is the expected behavior?

Your environment:

@titouancreach titouancreach added the unconfirmed Problem is not confirmed yet label Jun 13, 2024
@AugustinasMK
Copy link

React 19 isn't released as stable yet.

@simonwep
Copy link
Owner

simonwep commented Jul 2, 2024

I second this @AugustinasMK, I'm currently only building this against stable versions.

@simonwep simonwep added invalid This doesn't seem right @viselect/react React package and removed unconfirmed Problem is not confirmed yet labels Jul 2, 2024
@titouancreach
Copy link
Author

maybe we can anticipate a little bit and not wait for the user to complain to start to think to a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right @viselect/react React package
Projects
None yet
Development

No branches or pull requests

3 participants