Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Mobileclient.rate_songs is buggy for searched songs that are also in the library #573

Open
oprypin opened this issue Sep 24, 2017 · 2 comments

Comments

@oprypin
Copy link

oprypin commented Sep 24, 2017

I was using Mobileclient.search, aggregated results from a multiple searches, and put them into .rate_songs(results, '5'). What I noticed is that songs that happened to be in my library were all unaffected by this call, while all others were successfully thumbed up.

Then I used .get_all_songs() and matched them by storeId and replaced the previous results with these library results whenever possible (these have the id in them).
I got the following error:
gmusicapi.exceptions.CallFailure: BatchMutateTracks: the server's response could not be understood. The call may still have succeeded, but it's unlikely.
(response was: '')
But the songs were successfully thumbed up anyway.

Because this was a one-time project for me and I found a workaround anyway, this is not an important issue for me, but I thought I'd let you know.

@simon-weber
Copy link
Owner

Huh, weird. I've only ever seen the inverse (library tracks working fine, but non-library tracks causing issues).

@thebigmunch
Copy link
Contributor

There's a fair chance this is because the endpoint used to rates songs in gmusicapi isn't actually how the Google mobile clients do it. They only allow you to rate songs while playing them. And it uses the activity/recordrealtime endpoint or maybe just the activity/record endpoint (I seem to have lost my capture for this and can't check it on Android 7).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants