Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaiterOverlay updates #3912

Merged
merged 7 commits into from
Jul 25, 2023
Merged

WaiterOverlay updates #3912

merged 7 commits into from
Jul 25, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Jul 21, 2023

A few updates of PR #3876:

  • Change way to handle parent/setParent
  • Defer resize handling in eventHandler
  • For PlotWidget parent: Support change of backend and toolbars/dockwidgets
  • Changed name to WaitingOverlay to be inline with WaitingPushButton
  • Added a text getter and a test.

There is an issue when text is set: the size is not enlarged. It probably comes from WaitingPushButton.

@t20100 t20100 requested a review from payno July 21, 2023 10:00
@t20100 t20100 mentioned this pull request Jul 21, 2023
Merged
3 tasks
@vallsv vallsv merged commit 19cc5e1 into silx-kit:fix_3807 Jul 25, 2023
@vallsv
Copy link
Contributor

vallsv commented Jul 25, 2023

👍

@t20100 t20100 deleted the pr3876 branch October 23, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@payno payno payno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t20100 @vallsv @payno