Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeSet::removeObject() should handle case of implicit added item being removed. #415

Open
sabina-talipova opened this issue Oct 9, 2023 · 0 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 9, 2023

Description

Changesets can have items added implicitly. In that scenario, there may be no ChangeSetItem record in the database, so the current implementatio of removeObject() won't remove that implicit changeset item.

We should add logic to this method to check for implicit changeset items, and mark them as removed so they're not included in the actionable changeset.

See

if ($item) {
// TODO: Handle case of implicit added item being removed.
$item->delete();
}

@sabina-talipova sabina-talipova changed the title TODO: Handle case of implicit added item being removed TODO: ChangeSet::removeObject() should handle case of implicit added item being removed. Oct 10, 2023
@GuySartorelli GuySartorelli changed the title TODO: ChangeSet::removeObject() should handle case of implicit added item being removed. ChangeSet::removeObject() should handle case of implicit added item being removed. Oct 19, 2023
@sabina-talipova sabina-talipova self-assigned this Oct 23, 2023
@sabina-talipova sabina-talipova removed their assignment Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant