You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changesets can have items added implicitly. In that scenario, there may be no ChangeSetItem record in the database, so the current implementatio of removeObject() won't remove that implicit changeset item.
We should add logic to this method to check for implicit changeset items, and mark them as removed so they're not included in the actionable changeset.
sabina-talipova
changed the title
TODO: Handle case of implicit added item being removed
TODO: ChangeSet::removeObject() should handle case of implicit added item being removed.
Oct 10, 2023
GuySartorelli
changed the title
TODO: ChangeSet::removeObject() should handle case of implicit added item being removed.
ChangeSet::removeObject() should handle case of implicit added item being removed.
Oct 19, 2023
Description
Changesets can have items added implicitly. In that scenario, there may be no
ChangeSetItem
record in the database, so the current implementatio ofremoveObject()
won't remove that implicit changeset item.We should add logic to this method to check for implicit changeset items, and mark them as removed so they're not included in the actionable changeset.
See
silverstripe-versioned/src/ChangeSet.php
Lines 215 to 219 in 5359490
The text was updated successfully, but these errors were encountered: