Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridField config doesn't use Injector to create components #1327

Closed
2 tasks done
mfendeksilverstripe opened this issue Sep 8, 2024 · 3 comments
Closed
2 tasks done

Comments

@mfendeksilverstripe
Copy link
Contributor

Module version(s) affected

6.2.9

Description

GridField config doesn't use Injector to create components. This causes some customisations to be more complicated than they need to be.

How to reproduce

Using Injector to override GridField components won't be applied to this module as it doesn't use Injector.

Possible Solution

Use injector to create GridField components.

Additional Context

No response

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)
@GuySartorelli
Copy link
Member

Thanks for raising this. This won't be prioritised by the CMS Squad, but I'll happily review a pull request if you submit one

@mfendeksilverstripe
Copy link
Contributor Author

Created #1330 to fix this.

@GuySartorelli
Copy link
Member

PR merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants