Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish SiteConfig related images on save #5

Closed
NightJar opened this issue Jan 23, 2018 · 1 comment · Fixed by #6
Closed

Publish SiteConfig related images on save #5

NightJar opened this issue Jan 23, 2018 · 1 comment · Fixed by #6
Labels
affects/v4 complexity/medium impact/high type/UX
Milestone
Sprint 5

Comments

@NightJar
Copy link
Contributor

E.g. the Logo and FooterLogo will not show without first being published, and at current SiteConfig is not performing this action. Check the extension that applies these relations also adds an owns, and that SiteConfig performs a recursive publish (or is Versioned) when saved/published.
@robbieaverill
Copy link
Contributor

Related: silverstripe/silverstripe-siteconfig#1

For now we should add an onAfterWrite hook for publishing these associated images when you save a SiteConfig record.

@robbieaverill robbieaverill reopened this Jan 23, 2018
@rupachup rupachup added this to the Sprint 5 milestone Jan 23, 2018
@NightJar NightJar mentioned this issue Jan 24, 2018
Merged
@NightJar NightJar removed their assignment Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/high type/UX
Projects
None yet
Milestone
Sprint 5
Development

Successfully merging a pull request may close this issue.

Pulls/2.0/autopublish attached assets creative-commoners/cwp-agencyextensions
3 participants
@NightJar @robbieaverill @rupachup