Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max (max) steps - 50,000 #51

Closed
johnml1135 opened this issue Oct 31, 2023 · 2 comments · Fixed by #55
Closed

max (max) steps - 50,000 #51

johnml1135 opened this issue Oct 31, 2023 · 2 comments · Fixed by #55
Assignees
Labels
enhancement New feature or request

Comments

@johnml1135
Copy link
Collaborator

What if a person specifies 10,000,000 steps? Let's have a realistic limit. 50,000 is good enough - 20,000 is the "normal" max steps.

@johnml1135 johnml1135 added the enhancement New feature or request label Oct 31, 2023
@johnml1135 johnml1135 added this to the 1.2 Mother Tongue release 2 milestone Oct 31, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Oct 31, 2023
@mshannon-sil
Copy link
Collaborator

@johnml1135 If the user specifies a number of steps larger than the max amount of steps, should we fail the job and give them a chance to reenter a max steps that is under the limit? Or should we just automatically change it to the upper limit of 50000 while logging a warning without failing? The second option would be a smoother experience, although it wouldn't be as transparent to the user since I'm not sure that users will be able to see warning logs in machine.py.

@ddaspit
Copy link
Contributor

ddaspit commented Nov 1, 2023

We should throw an error if they are over the limit.

@mshannon-sil mshannon-sil linked a pull request Nov 2, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Serval Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants