-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process node.exe doesn't exit when close the window #35
Comments
This is a complex issue since chrome (the window) starts its own process and then exits immediately. Also sometimes chrome decides to "join" or re-use an existing browser process that is running, this means that it is quite difficult to detect when the window process closes. However the code is getting better on this point. Try the following:-
We are still looking for best practices to solve this issue, as we discover good solutions we can update the main deskshell implementation. |
Thanks for replying. |
We will be moving to a cef3 based browser instead of chrome soon (code is working on mac already). This should solve the problem, when lanching the window we will get the process id and then know when it closes. This should fix the entire issue as well as give further benefits. So if you can live with the issue for now it should go away soon. |
I use window.onbeforeunload event instead of window.onunload because the window.onunload also trigger when refresh the window, which is unwanted. |
Sometimes, when you launch a app and hang it there for about half an hour, and then you click the close button of the window, it closed, but the node.exe process is still there in the task managar when you check it.
Is there any way to fix this out? pls
This cause a issue that when you run the app for several times, and there will be a bunch of processes of node.exe in the system
maybe this can be called "bug".
in file "index.js" at "deskshell-api"
at about line 97
app.rDebugApi.on('*',function(event) {...}
this listener only work once
it was defined in "index.js" at "chrome-rDebug"
at about line 619 and
used at about line 645
they only work once.
The text was updated successfully, but these errors were encountered: