decouple eth2
from store
and lighthouse_network
#6680
+95
−86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Remove dependencies on
store
andlighthouse_network
frometh2
. This was achieved as follows:enr
andmultiaddr
directly instead of usinglighthouse_network
's reexports.lighthouse_network
responsible for converting between API and internal types.serde_json::Value
instead - this is not ideal, but should be fine for now, as this affects two internal non-spec endpoints which are meant for debugging, unstable, and subject to change without notice anyway. Inspired by Remove lighthouse_network dependency from eth2 crate #6679. The alternative is to move all relevant types toeth2
ortypes
instead - what do you think?Additional Info
In my opinion, this only partially fixes the issue above, as we probably still should split out lighthouse-specific features.