-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write range sync tests in external event-driven form #6618
base: unstable
Are you sure you want to change the base?
Conversation
rig.remember_block(finalized_peer_block); | ||
|
||
// Add an additional peer to the second chain to make range update it's status | ||
rig.add_finalized_peer(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what this line does - do we need to assert for some condition after doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I respected the original test sequence as written in #2827, it covered a bug which this final line triggered a debug assertion
Nice! Looks clean and easy to read 👍 |
This test is failing in CI after switching to async, but can't reproduce locally |
Issue Addressed
Re-write existing range sync tests into an event-driven format to accommodate the refactor introduced in
This format was introduced in
and does not make assumptions about internal functions, it treats sync as a black box inputting actual events used in production.
Note: I've removed the generics used in range sync since now we don't unit test directly