Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI flag for HTTP API token path (VC) #6577

Open
wants to merge 15 commits into
base: unstable
Choose a base branch
from
Open

Add CLI flag for HTTP API token path (VC) #6577

wants to merge 15 commits into from
+96 −18

Conversation

syjn99
Copy link

@syjn99 syjn99 commented Nov 9, 2024 •
edited
Loading

Issue Addressed

#6563

Proposed Changes

  • Added http-token-path flag for users who want to set the token path explicity.
  • Added documentation for CLI reference, etc.

Additional Info

  • Throw error when http-token-path is actually a directory.
  • If parent directory doesn't exist, make parent directory.

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@syjn99 syjn99 changed the title [WIP] Add cli flag for HTTP API token path (VC) Add cli flag for HTTP API token path (VC) Nov 10, 2024
@syjn99 syjn99 changed the title Add cli flag for HTTP API token path (VC) Add CLI flag for HTTP API token path (VC) Nov 10, 2024
@syjn99 syjn99 marked this pull request as ready for review November 10, 2024 06:00
michaelsproul
michaelsproul requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

This looks good on the whole, just a few minor tweaks and then we can merge

validator_client/src/cli.rs Outdated Show resolved Hide resolved
validator_client/src/config.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Nov 15, 2024
@syjn99
Copy link
Author

syjn99 commented Nov 18, 2024

@michaelsproul
Fixed things you mentioned! Sorry for delay, enjoyed Devcon a lot 🙇‍♂️

@syjn99 syjn99 requested a review from michaelsproul November 18, 2024 10:34
@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 20, 2024
chong-he
chong-he reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@chong-he chong-he left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some manual testing and it works well!

book/src/help_vc.md Outdated Show resolved Hide resolved
@syjn99 syjn99 requested a review from chong-he November 20, 2024 12:02
@syjn99
Copy link
Author

syjn99 commented Nov 24, 2024

@michaelsproul @chong-he
Could you please check this one more time? I applied reviews, fixed things that broke CI jobs.

@michaelsproul michaelsproul added the v6.1.0 New release c. Q1 2025 label Dec 3, 2024
@syjn99
Copy link
Author

syjn99 commented Dec 3, 2024

@michaelsproul It seems that there are some flaky tests for make test-network. I'm not sure but it might be related to #6646.

jimmygchen
jimmygchen approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

@chong-he chong-he Awaiting requested review from chong-he

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v6.1.0 New release c. Q1 2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@syjn99 @CLAassistant @jimmygchen @michaelsproul @chong-he