diff --git a/beacon_node/lighthouse_network/src/config.rs b/beacon_node/lighthouse_network/src/config.rs index fb005e08943..5d84753781f 100644 --- a/beacon_node/lighthouse_network/src/config.rs +++ b/beacon_node/lighthouse_network/src/config.rs @@ -468,8 +468,6 @@ pub fn gossipsub_config( ) -> Vec { let topic_bytes = message.topic.as_str().as_bytes(); match fork_context.current_fork() { - // according to: https://github.com/ethereum/consensus-specs/blob/dev/specs/merge/p2p-interface.md#the-gossip-domain-gossipsub - // the derivation of the message-id remains the same in the merge and for eip 4844. ForkName::Altair | ForkName::Merge | ForkName::Capella | ForkName::Deneb => { let topic_len_bytes = topic_bytes.len().to_le_bytes(); let mut vec = Vec::with_capacity( diff --git a/beacon_node/network/src/router.rs b/beacon_node/network/src/router.rs index 7248147178e..4df940a3b79 100644 --- a/beacon_node/network/src/router.rs +++ b/beacon_node/network/src/router.rs @@ -540,7 +540,7 @@ impl Router { seen_timestamp: timestamp_now(), }); } else { - debug!( + crit!( self.log, "All blobs by range responses should belong to sync" ); diff --git a/beacon_node/network/src/sync/block_lookups/mod.rs b/beacon_node/network/src/sync/block_lookups/mod.rs index fd9d0d6e0e4..3f1ecd129b6 100644 --- a/beacon_node/network/src/sync/block_lookups/mod.rs +++ b/beacon_node/network/src/sync/block_lookups/mod.rs @@ -49,7 +49,7 @@ pub type DownloadedBlock = (Hash256, RpcBlock); const FAILED_CHAINS_CACHE_EXPIRY_SECONDS: u64 = 60; pub const SINGLE_BLOCK_LOOKUP_MAX_ATTEMPTS: u8 = 3; -/// This enum is used to track what a peer *should* be able to respond with respond based on +/// This enum is used to track what a peer *should* be able to respond with based on /// other messages we've seen from this peer on the network. This is useful for peer scoring. /// We expect a peer tracked by the `BlockAndBlobs` variant to be able to respond to all /// components of a block. This peer has either sent an attestation for the requested block @@ -449,7 +449,7 @@ impl BlockLookups { } } CachedChild::DownloadIncomplete => { - // If this was the result of a block request, we can't determined if the block peer + // If this was the result of a block request, we can't determine if the block peer // did anything wrong. If we already had both a block and blobs response processed, // we should penalize the blobs peer because they did not provide all blobs on the // initial request. diff --git a/book/src/developers.md b/book/src/developers.md index 2ba09bd3412..ab12bed5b94 100644 --- a/book/src/developers.md +++ b/book/src/developers.md @@ -48,4 +48,5 @@ custom RPC error messages. | Code | Message | Description | | ---- | ---- | ---- | -| 139 | Rate Limited | The peer has been rate limited so we return this error as a response | \ No newline at end of file +| 139 | Rate Limited | The peer has been rate limited so we return this error as a response | +| 140 | Blobs Not Found For Block | We do not possess the blobs for the requested block |