Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with the extention permit-x11-forwarding #230

Closed
cyber-anon opened this issue Jul 17, 2024 · 1 comment · Fixed by #231
Closed

problem with the extention permit-x11-forwarding #230

cyber-anon opened this issue Jul 17, 2024 · 1 comment · Fixed by #231

Comments

@cyber-anon
Copy link
Contributor

Using viper to read the config file, creates a problem with the SSH certificate extension "permit-X11-forwarding" which is converted to lowercase "permit-x11-forwarding" and thus is invalid / unknown.

I do not know how this could be solved.
This seems to be an inherent limitation of viper older than 5 years, and the most common solution people are implementing, is to migrate to another package.

spf13/viper#1014

Since the only case-sensitive extension is this, maybe a solution would be to iterate the Extensions map after being created, and if permit-x11-forwarding is found, modify it with the correct capitalization

@pablo-ruth
Copy link
Contributor

Hi @cyber-anon, sorry for the delay. It's not the most elegant solution, but checking this edge case and fixing it is the simplest way. I've merged the fix and released it here: https://github.com/signmykeyio/signmykey/releases/tag/v0.8.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants