Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: profiling: properly format trace context strings #372

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix: profiling: properly format trace context strings #372

merged 2 commits into from
Nov 29, 2023

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Nov 29, 2023

trace and span ids were formatted with 0x prefix and this went unnoticed in the tests.

@seemk seemk requested review from a team as code owners November 29, 2023 17:03
@seemk seemk requested a review from a team as a code owner November 29, 2023 17:04
@pmcollins
Copy link
Contributor

Siim, can we also add a test that fails before this change but succeeds after it?

@seemk
Copy link
Contributor Author

seemk commented Nov 29, 2023

Siim, can we also add a test that fails before this change but succeeds after it?

I modified the existing test to check for 0x

@seemk seemk merged commit 86343c7 into main Nov 29, 2023
16 checks passed
@seemk seemk deleted the fix-profiling-tracectx-fmt branch November 29, 2023 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pmcollins pmcollins pmcollins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seemk @pmcollins