sampling: use session id for source of randomness #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbley
approved these changes
Nov 27, 2023
Android has the same issue. The lower 8 bytes of the session ID are converted to a number, this differs from the JS RUM implementation which xors the whole 16 bytes in 4 byte chunks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the session ID bytes for the source of randomness when making a sampling decision.
The algorithm for the session ID value calculation is the same as is in the JS RUM SDK. This fixes the issue where, if sampling is used with the iOS SDK and inside a WebView, the SDKs come to a different sampling decision due to differing algorithms.
Note: session ID callbacks should have the session ID as a parameter, but this would be a breaking change in the public API, so I decided to keep the plain callbacks for now.