-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SauceLabs tests to CI #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhennoch
reviewed
Nov 1, 2023
johnbley
approved these changes
Nov 2, 2023
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: ['14', '15', '16'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I really like that the test matrix is in github rather than in SauceLabs UI/config.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's now a new project, SauceLabsTestApp, which runs through a few (mostly) networking tests. The app sets up its own HTTP server which is then used to route the spans to tests for verification.
I tried to bring in some order to the tests, all tests derive from
TestCase
, which sets up some central bookkeeping (handles timeouts, attaches test names to spans, routes test results).When creating new tests, only 2 methods need to be overridden:
execute
- sets up the test, e.g. start an HTTP request andverify
which is called with the received spans.Since it's a bit annoying to verify the results in Sauce Labs, I just created a label that changes the text to
success
when all tests pass. Sauce Labs waits for this label.Areas that need more work: