Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetMeterProvider panics if two connections are open #3430

Closed
blkt opened this issue Sep 19, 2024 · 3 comments
Closed

SetMeterProvider panics if two connections are open #3430

blkt opened this issue Sep 19, 2024 · 3 comments
Labels
bug Something isn't working question Further information is requested

Comments

@blkt
Copy link

blkt commented Sep 19, 2024

Describe the issue
Dependabot opened the following PR upgrading several opentelemetry dependencies in an open source project I'm maintaining.
Accepting the change causes panics for some reasons that are unclear to me, but that I managed to reproduce in a simpler script here.

Here's the list of upgrades.

Package From To
go.opentelemetry.io/otel/exporters/prometheus 0.51.0 0.52.0
go.opentelemetry.io/otel/exporters/stdout/stdouttrace 1.29.0 1.30.0
go.opentelemetry.io/otel/sdk 1.29.0 1.30.0
go.opentelemetry.io/otel/sdk/metric 1.29.0 1.30.0
go.opentelemetry.io/otel/trace 1.29.0 1.30.0
go.opentelemetry.io/otel/metric 1.29.0 1.30.0

I am opening the issue in this project because it only manifests with this tracing library, and splunk-otel-go version 1.19.0 with otel libraries at version 1.29.0 did not manifest this behavior.

Steps to reproduce the issue:
Use https://github.com/blkt/panicrepro to reproduce.
Branch main panics.
Branch working-version does not panic.

Attempted solutions and workarounds
No workarounds were attempted.

Expected behavior
Opening two connections should not cause any sort of panic.

Environment
Complete the following information:

  • OS version: macOS 14.6.1
  • Go version: 1.23.1
  • splunk-otel-go version: 1.20.0
@blkt blkt added the bug Something isn't working label Sep 19, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Sep 19, 2024

This looks related to open-telemetry/opentelemetry-go#5827

@pellared
Copy link
Contributor

pellared commented Dec 13, 2024

@blkt, can you please check if are you still able to reproduce it with https://github.com/signalfx/splunk-otel-go/releases/tag/v1.22.0?

@pellared pellared added the question Further information is requested label Dec 13, 2024
@blkt
Copy link
Author

blkt commented Dec 14, 2024

@pellared we're already using version v1.22.0 in production, works for us.
https://github.com/mindersec/minder/blob/main/go.mod#L65-L66

Thank you for the work! 🙏

@MrAlias MrAlias closed this as completed Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants