Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimizing to system tray causes window to forget it was maximized #6119

Open
2 tasks done
ellisonch opened this issue Sep 17, 2022 · 4 comments · May be fixed by #6751
Open
2 tasks done

minimizing to system tray causes window to forget it was maximized #6119

ellisonch opened this issue Sep 17, 2022 · 4 comments · May be fixed by #6751
Labels

Comments

@ellisonch
Copy link

ellisonch commented Sep 17, 2022

  • I have searched open and closed issues for duplicates
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

Minimizing to system tray causes Signal to forget it was maximized. Upon re-opening, the window will revert to the "normal" state of being un-maximized.

Steps to Reproduce

  1. Make sure "minimize to system tray" is set in preferences
  2. Maximize the Signal window
  3. Minimize the Signal window (it goes into the system tray)
  4. Go to the system tray and open the Signal window back up

Actual Result:

Signal will pop up and be un-maximized ("normal" window state)

Expected Result:

It should remember that the window was maximized and reappear maximized. This is the behavior if you "X" the window to the system tray. Only minimizing to system tray causes it to forget it was maximized.

Platform Info

Signal Version: 5.59.0 production

Operating System: Windows 10

@indutny-signal
Copy link
Contributor

I tried reproducing it with 5.60.0, but it seems that it is fixed now. Does it still happen for you on the latest production release?

@ellisonch
Copy link
Author

It seems to be fixed on 5.60.0.

It looks like they totally changed the way minimize works (for the better, I think). Now X goes to the tray, while minimize just minimizes, which is how other programs work.

@ellisonch
Copy link
Author

ellisonch commented Jun 28, 2023

It seems like this issue is still happening via slightly different inputs.

Steps to Reproduce

  • Make sure "minimize to system tray" is set in preferences;
  • Open and maximize the Signal window;
  • Minimize the Signal window (it minimizes to the taskbar);
  • Click on the system tray icon (This causes the minimized program to hide into to the system tray, disappearing from the taskbar);
  • Click the system tray icon again to open the Signal window back up

At this point, the window will be unmaximized, having forgotten it was maximized previously.

This is on windows desktop 6.22.0 production, on Windows 10.

@ellisonch
Copy link
Author

It looks like 6.23.0 changed the behavior a little, but the bug is still there.

Now,

  • Make sure "minimize to system tray" is set in preferences;
  • Open and maximize the Signal window;
  • Minimize the Signal window (it minimizes to the taskbar);
  • Click on the system tray icon (This causes the minimized program to open back up)

At this point, the window will be unmaximized, having forgotten it was maximized previously.

ellisonch added a commit to ellisonch/Signal-Desktop that referenced this issue Jan 18, 2024
ellisonch added a commit to ellisonch/Signal-Desktop that referenced this issue Jan 18, 2024
…) the window if it was previously minimized, instead of show()ing it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants