Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS independence #89

Open
GreenK173 opened this issue Dec 19, 2024 · 1 comment
Open

OS independence #89

GreenK173 opened this issue Dec 19, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@GreenK173
Copy link
Contributor

According to pyproject.toml, this library should be OS independent. However I've found two cases where the code only works on Unix platforms but not on Windows. One was during discussion of PR #81. The other one is the use of os.sched_getaffinity in validate.py, which is only available on Unix (as mentioned at the beggining of the section in the doc).

@Teque5 Teque5 added bug Something isn't working help wanted Extra attention is needed labels Dec 19, 2024
@Teque5
Copy link
Collaborator

Teque5 commented Dec 19, 2024

Thanks for noting this issue with windows. We can either leave a note where we manually garbage collect (specifically for this windows issue) or we can find a function that can remove the memmap file.

I wonder, does pathlib.Path.unlink() work for this problem? Generally I think we should have all our paths in this module handled by pathlib anyway, but it's just been on the to-do list. In unix unlink() will either remove the file or the softlink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants