Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing clarification for empty captures array #326

Closed
bbc131 opened this issue Dec 17, 2024 · 1 comment · Fixed by #327
Closed

Missing clarification for empty captures array #326

bbc131 opened this issue Dec 17, 2024 · 1 comment · Fixed by #327

Comments

@bbc131
Copy link
Contributor

bbc131 commented Dec 17, 2024

PR #293 explicitly added some clarification, that there should be at last one element in the captures array, but doesn't have to.
I'm not sure if this was intentionally dropped with #301, but for me this clarification was justified and is missing now.
@777arc
Copy link
Member

777arc commented Dec 17, 2024

Ah nice catch, I'll get it added back in

@777arc 777arc mentioned this issue Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Empty captures array implies start sample of 0 sigmf/SigMF
2 participants
@777arc @bbc131