feat(cmd): use dot to specify current dir when using --outdir flag

[luigidematteis]

Summary

This PR solves the issue #508.

In addition to the --outdir flag for the apply command, the same behavior has been implement also for the other commands that use the same flag, which are: delete cluster, diff, connect openvpn and dump template.

Testing

• Check if the furyctl apply --outdir . works without issues:

furyctl apply --outdir . --debug
DEBU logging to: .furyctl/furyctl.1732099416-96165.log 
DEBU Set outDir to currentDir: /*/fury/minikube-fury-cluster
INFO Downloading distribution...                  
INFO Compatibility patches applied for v1.29.4    
INFO Validating configuration file...             
INFO Downloading dependencies...                  
DEBU Cleaning vendor folder                       
INFO Validating dependencies...                   
INFO Running preflight checks                     
... 
Apply script completed.
INFO Kubernetes Fury Distribution installed successfully 
INFO Applying plugins...                          
DEBU config path = /var/folders/gx/dy2nbmh950df3qzkh3_dfrsc0000gn/T/furyctl-plugins-3451290346/config.yaml 
INFO Skipping plugins phase as spec.plugins is not defined 
INFO Saving furyctl configuration file in the cluster... 
secret/furyctl-config serverside-applied
INFO Saving distribution configuration file in the cluster... 
secret/furyctl-kfd serverside-applied

• Check dump template command

INFO Downloading distribution...                  
INFO Compatibility patches applied for v1.29.4    
INFO Validating configuration file...             
INFO Generating distribution manifests...         
INFO Distribution manifests generated successfully 

• Check if dump template --workdir x --outdir . works as expected (the .furyctl is created in the current directory, not in the workdir)

# $(PWD) == folder_x
furyctl dump template --workdir /folder_y -o .
...
ls /folder_x
.furyctl

• Check diff command

furyctl diff --workdir /tmp -o .
INFO Downloading distribution...                  
INFO Compatibility patches applied for v1.29.4    
INFO No differences found from previous cluster configuration 

• Check connect openvpn command

Work in progress...

• Check delete cluster command

furyctl delete cluster --workdir $(PWD) --outdir .
INFO Downloading distribution...                  
INFO Compatibility patches applied for v1.29.4    
INFO Validating configuration file...             
INFO Downloading dependencies...                  
INFO Validating dependencies...                   
WARNING: You are about to delete a cluster. This action is irreversible.
Are you sure you want to continue? Only 'yes' will be accepted to confirm.
yes
INFO Running preflight checks                     
INFO Checking that the cluster is reachable...    
INFO Preflight checks completed successfully      
INFO Deleting Kubernetes Fury Distribution...     
INFO Checking that the cluster is reachable...    
INFO Checking storage classes...                  
INFO Deleting kubernetes resources...             
...

Breaking changes:

There are not breaking changes.

[g-iannelli]

I don't like the change in default behavior for --output-dir. Using the user's home directory is safer than using the current directory. No one can guarantee that someone won't run a command like furyctl dump template -c /dir1/dir2/dir3/furcytl.yaml and write it to the current directory (which is unknown) instead of using the user's home.

IMHO the user's home should be the default and the check for the --output-dir == . should be added in addition.

[g-iannelli]

Moreover the fix doen't work in case of --workdir is specified

pwd && go run main.go dump template -D -w /tmp -o .
~/Workspace/github.com/luigidematteis/furyctl
DEBU logging to: .furyctl/furyctl.1732113133-33825.log
DEBU Changed working directory to /tmp
DEBU Getting Home Directory Path...
INFO Downloading distribution...
INFO Compatibility patches applied for v1.29.4
INFO Validating configuration file...
INFO Generating distribution manifests...
DEBU config path = /var/folders/k9/3lv0pm253td7mqnyhqfryprw0000gn/T/furyctl-dist-2246877313/config.yaml
DEBU output directory = /private/tmp/distribution
INFO Distribution manifests generated successfully

With the old $(pwd) workaround it works fine

pwd && go run main.go dump template -D -w /tmp -o $(pwd)
~/Workspace/github.com/luigidematteis/furyctl
DEBU logging to: ~/Workspace/github.com/luigidematteis/furyctl/.furyctl/furyctl.1732113242-9295.log
DEBU Changed working directory to /tmp
DEBU Getting Home Directory Path...
INFO Downloading distribution...
INFO Compatibility patches applied for v1.29.4
INFO Validating configuration file...
INFO Generating distribution manifests...
DEBU config path = /var/folders/k9/3lv0pm253td7mqnyhqfryprw0000gn/T/furyctl-dist-3600317983/config.yaml
DEBU output directory = ~/Workspace/github.com/luigidematteis/furyctl/distribution
INFO Distribution manifests generated successfully

[luigidematteis]

I don't like the change in default behavior for --output-dir. Using the user's home directory is safer than using the current directory. No one can guarantee that someone won't run a command like furyctl dump template -c /dir1/dir2/dir3/furcytl.yaml and write it to the current directory (which is unknown) instead of using the user's home.

IMHO the user's home should be the default and the check for the --output-dir == . should be added in addition.

Hi @g-iannelli, I got your point, but this change was only for the apply command, not for dump template. In any case, I agree that it would be better to just add it as an additional check.

Regarding the dump template command, I just noticed that we already had a check for setting the currentDir, but it was not working because we was checking if value of outDir was empty instead of .

I made a fix for that as well.