Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validateTools could panic in case of a non-existing or non-supported tool #551

Open
kriive opened this issue Oct 24, 2024 · 0 comments
Open

validateTools could panic in case of a non-existing or non-supported tool #551

kriive opened this issue Oct 24, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers size/XXS

Comments

@kriive
Copy link

kriive commented Oct 24, 2024

In the following snippet here, we fail to check for nil value, after Createing the tool.

furyctl/internal/dependencies/tools/validator.go

Lines 125 to 126 in ba7dc1d

tool := tv.toolFactory.Create(itool.Name(toolName), toolCfg.Version)
if err := tool.CheckBinVersion(); err != nil {

@kriive kriive added bug Something isn't working size/XXS good first issue Good for newcomers labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers size/XXS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kriive