From 2f1605fd5cb0dfa303b01e6a1a73269125044b2b Mon Sep 17 00:00:00 2001
From: Lucas Kent <rubickent@gmail.com>
Date: Mon, 16 Oct 2023 14:50:00 +1100
Subject: [PATCH] CI: split lints + tests into seperate workflows

---
 .github/workflows/build_and_test.yaml | 11 +----
 .github/workflows/lint.yaml           | 65 +++++++++++++++++++++++++++
 2 files changed, 67 insertions(+), 9 deletions(-)
 create mode 100644 .github/workflows/lint.yaml

diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml
index 2b96839da..cdca4baf7 100644
--- a/.github/workflows/build_and_test.yaml
+++ b/.github/workflows/build_and_test.yaml
@@ -57,17 +57,10 @@ jobs:
         key: ubuntu-20.04-packages
     - name: Install ubuntu packages
       run: shotover-proxy/build/install_ubuntu_packages.sh
-    - name: Install cargo-hack and nextest
+    - name: Install nextest
       uses: taiki-e/install-action@v2
       with:
-        tool: cargo-hack@0.6.4,nextest@0.9.57
-    - name: Check `cargo fmt` was run
-      run: cargo fmt --all -- --check
-    - name: Ensure that all crates compile and have no warnings under every possible combination of features
-      # some things to explicitly point out:
-      # * clippy also reports rustc warnings and errors
-      # * clippy --all-targets causes clippy to run against tests and examples which it doesnt do by default.
-      run: cargo hack --feature-powerset clippy --all-targets --locked ${{ matrix.cargo_flags }} -- -D warnings
+        tool: nextest@0.9.57
     - name: Build tests
       run: |
         cargo test --doc ${{ matrix.cargo_flags }} --all-features -- --show-output --nocapture
diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
new file mode 100644
index 000000000..93ae2a536
--- /dev/null
+++ b/.github/workflows/lint.yaml
@@ -0,0 +1,65 @@
+name: Formatting and lints
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+# Cancel already running jobs
+concurrency:
+  group: lints
+  cancel-in-progress: true
+
+env:
+  CARGO_TERM_COLOR: always
+  RUST_BACKTRACE: 1
+
+jobs:
+  job:
+    name: Formatting and lints
+    runs-on: ubuntu-20.04
+    steps:
+    - uses: actions/checkout@v3
+    - uses: Swatinem/rust-cache@v2
+      with:
+        # this line means that only the main branch writes to the cache
+        # benefits:
+        # * prevents main branch caches from being evicted in favor of a PR cache
+        # * saves about 1min per workflow by skipping the actual cache write
+        # downsides:
+        # * PRs that update rust version or changes deps will be slow to iterate on due to changes not being cached.
+        save-if: ${{ github.ref == 'refs/heads/main' }}
+    - name: cache custom ubuntu packages
+      uses: actions/cache@v3
+      with:
+        path: shotover-proxy/build/packages
+        key: ubuntu-20.04-packages
+    - name: Install ubuntu packages
+      run: shotover-proxy/build/install_ubuntu_packages.sh
+    - name: Install cargo-hack
+      uses: taiki-e/install-action@v2
+      with:
+        tool: cargo-hack@0.6.4
+    - name: Ensure `cargo fmt --all` was run
+      run: cargo fmt --all -- --check
+    - name: Ensure that all crates compile and have no warnings under every possible combination of features
+      # some things to explicitly point out:
+      # * clippy also reports rustc warnings and errors
+      # * clippy --all-targets causes clippy to run against tests and examples which it doesnt do by default.
+      run: cargo hack --feature-powerset clippy --all-targets --locked -- -D warnings
+    - name: Report disk usage
+      run: |
+        df -h
+
+        echo -e "\ntarget dir usage:"
+        du -h $PWD/target
+
+        echo -e "\n.cargo dir usage:"
+        du -h ~/.cargo
+    - name: Ensure that tests did not create or modify any files that arent .gitignore'd
+      run: |
+        if [ -n "$(git status --porcelain)" ]; then
+          git status
+          exit 1
+        fi