Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on ADOBE environment variables. #9

Open
manneohrstrom opened this issue Mar 17, 2019 · 0 comments
Open

Pass on ADOBE environment variables. #9

manneohrstrom opened this issue Mar 17, 2019 · 0 comments
Milestone

Comments

@manneohrstrom
Copy link
Contributor

manneohrstrom commented Mar 17, 2019

Summary

We should do a pass on the various environment variables to ensure they are in the right place. I am seeing a lot of stuff on the engine level that looks like it likely belongs at the framework level and in some cases it is defined in both the engine and the framework, which is bad.

The goal: Get as many of the environment variables into the framework as possible. Update the documentation to reflect the new state (wiki + sphinx, adobe fw, AE engine, PS engine).

Examples of duplicate definitions

  • It looks like the SHOTGUN_ADOBE_NETWORK_DEBUG environment is defined both in the engine and in the framework - we should refactor this to be less leaky. I think we should drop the network_debug flag and the only way to control the debug state is through the SHOTGUN_ADOBE_NETWORK_DEBUG env var, which is only accessed from the fw.
  • I am seeing a similar situation for SHOTGUN_ADOBE_PYTHON.
@manneohrstrom manneohrstrom changed the title SHOTGUN_ADOBE_NETWORK_DEBUG leaky abstraction Pass on ADOBE environment variables. Mar 17, 2019
@manneohrstrom manneohrstrom added this to the v0.2 milestone Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant