Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check which dependencies should be set as prod dependencies and shipped with the docker image #15

Open
acelaya opened this issue Apr 27, 2024 · 0 comments · May be fixed by #59
Open

Check which dependencies should be set as prod dependencies and shipped with the docker image #15

acelaya opened this issue Apr 27, 2024 · 0 comments · May be fixed by #59
Labels
enhancement New feature or request
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Apr 27, 2024

When building for production, remix's vite plugin generates server and client bundles.

I assume client one will include dependencies as well, but this may not be the case for server dependencies.

If server dependencies are not bundled, part of node_modules will have to be added to the docker images, but making sure the client ones are not, as they will be wasting space.

If this assumption is correct, client dependencies should be defined as dev dependencies, and stripped out of the final image.

@acelaya acelaya added the enhancement New feature or request label Apr 27, 2024
@acelaya acelaya added this to the 0.1.0 milestone Apr 27, 2024
@acelaya acelaya added this to Shlink Apr 27, 2024
@acelaya acelaya moved this to Todo in Shlink Apr 27, 2024
@acelaya acelaya moved this from Todo to In Progress in Shlink May 25, 2024
@acelaya acelaya linked a pull request May 26, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant