Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

feat: add a resampling feature #41

Closed

Conversation

charles-zablit
Copy link
Contributor

This PR adds a resampling capability in whispering.

Adding a "source_sample_rate" with the sample rate of the source will resample the audio to 16 000 Hz.
It supports supersampling and undersampling.

This addresses #32 and will allow jitsi/jigasi#454 to be merged.

Please let me know if there is anything I can do to improve this PR.

@charles-zablit charles-zablit force-pushed the feat-add-resampling branch 3 times, most recently from c2426c8 to bc486b6 Compare October 20, 2022 14:08
@charles-zablit
Copy link
Contributor Author

I'm not sure why the CI fails :/

@shirayu
Copy link
Owner

shirayu commented Oct 21, 2022

Thank you for the PR.

However, I think the resampling should be done by the library clients.
Therefore, I am not in favor of adding this feature.
Thank you anyway.

Note: CI fails the code formatting is needed.
I'll add the command (#42).

@shirayu shirayu closed this Oct 21, 2022
@charles-zablit
Copy link
Contributor Author

Hello @shirayu,

I understand that this should be done by the client, as it's a cleaner implementation.

However, this feature would allow us to implement Whispering with Jitsi #41

Furthermore, VOSK server, which also allows live transcription, allows the user to specify the sample rate:
https://github.com/alphacep/vosk-server/blob/ce2c39556c5b44744a7e3a08ad964905c1420046/client-samples/python/asr-test.py#L12

Can you please reconsider merging this?

@shirayu
Copy link
Owner

shirayu commented Oct 21, 2022

Merging this pull request itself is easy.
However, adding various features makes maintenance difficult.
I would like to keep this library as simple as possible.
I am sorry, but please kindly understand this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants